arrow
返回

Does code quality affect pull request acceptance? An empirical study

delete2021-01-01
delete20
delete
OA
AI
V
Valentina Lenarduzzi
V
Vili Nikkola
N
Nyyti Saarimäki
D
Davide Taibi *
DOI:10.1016/j.jss.2020.110806delete
delete原文链接
delete分享
delete收藏
查看原文
摘要

摘要

En 中文
Background Pull requests are a common practice for making contributions and reviewing them in both open-source and industrial contexts. Objective Our goal is to understand whether quality flaws such as code smells, anti-patterns, security vulnerabilities, and coding style violations in a pull request's code affect the chance of its acceptance when reviewed by a maintainer of the project. Method We conducted a case study among 28 Java open-source projects, analyzing the presence of 4.7 M code quality flaws in 36 K pull requests. We analyzed further correlations by applying logistic regression and six machine learning techniques. Moreover, we manually validated 10% of the pull requests to get further qualitative insights on the importance of quality issues in cases of acceptance and rejection. Results Unexpectedly, quality flaws measured by PMD turned out not to affect the acceptance of a pull request at all. As suggested by other works, other factors such as the reputation of the maintainer and the importance of the delivered feature might be more important than other qualities in terms of pull request acceptance. Conclusions . Researchers have already investigated the influence of the developers' reputation and the pull request acceptance. This is the first work investigating code style violations and specifically PMD rules. We recommend that researchers further investigate this topic to understand if different measures or different tools could provide some useful measures. (c) 2020 The Authors. Published by Elsevier Inc. This is an open access article under the CC BY-NC-ND license (http://creativecommons.org/licenses/by-nc-nd/4.0/).
Keyword:
Pull requests
PMD rules
Machine learning
AI总结

AI总结

对已上传原文的论文进行重点信息的提取,主要内容包括:简要概述、研究摘要、背景介绍、关键亮点、图文解析、展望与总结。

期刊

Journal of Systems and Software 封面图
Journal of Systems and Software
IF:
4.1
论文数:
5.5K
被引数:
8.4K

机构

T
Tampere University
学者数:
1.4W
论文数: 1.3W
被引数: 1.4W
引用论文

引用论文

An in-depth study of the promises and perils of mining GitHub深入研究采矿GitHub的承诺和危险
err2015-09-05
err175
PREAI
errKalliamvakou, Eirini; Gousios, Georgios; Blincoe, Kelly; Singer, Leif; German, Daniel M.; Damian, Daniela
err分享
err收藏
Ureterovaginal Fistula: A Report of 12 Cases and Review of the Literature
err1982-11-01
err0
PREAI
errDenis M. Murphy; Pierce A. Grace; J. Dermot O’Flynn
err分享
err收藏
Gender differences and bias in open source: pull request acceptance of women versus men
err2017-05-01
err183
errOAAI
errTerrell, Josh; Kofink, Andrew; Middleton, Justin; Rainear, Clarissa; Murphy-Hill, Emerson; Parnin, Chris; Stallings, Jon
err分享
err收藏
Bagging predictorsBagging预测器
err1996-08-01
err1.0W
PREAI
errBreiman, L
err分享
err收藏
Evaluating the impact of design pattern and anti-pattern dependencies on changes and faults
err2015-03-10
err35
PREAI
errJaafar, Fehmi; Gueheneuc, Yann-Gael; Hamel, Sylvie; Khomh, Foutse; Zulkernine, Mohammad
err分享
err收藏
学者 查看更多内容