arrow
返回

Do code reviews lead to fewer code smells?

delete2024-09-01
delete2
PRE
AI
E
Erdem Tuna *
C
Carolyn Seaman
E
Eray Tüzün
DOI:10.1016/j.jss.2024.112101delete
delete原文链接
delete原文求助
delete分享
delete收藏
摘要

摘要

En 中文
Context: The code review process is conducted by software teams with various motivations. Among other goals, code reviews act as a gatekeeper for software quality. Objective: In this study, we explore whether code reviews have an impact on one specific aspect of software quality, software maintainability. We further extend our investigation by analyzing whether code review process quality (as evidenced by the presence of code review process smells) influences software maintainability (as evidenced by the presence of code smells). Method: We investigate whether smells in the code review process are related to smells in the code that was reviewed by using correlation analysis. We augment our quantitative analysis with a focus group study to learn practitioners' opinions. Results: Our investigations revealed that the level of code smells neither increases nor decreases in 8 out of 10 code reviews, regardless of the quality of the code review. Contrary to our own intuition and that of the practitioners in our focus groups, we found that code review process smells have little to no correlation with the level of code smells. We identified multiple potential reasons behind the counter-intuitive results based on our focus group data. Furthermore, practitioners still believe that code reviews are helpful in improving software maintainability. Conclusion: Our results imply that the community should update our goals for code review practices and reevaluate those practices to align them with more relevant and modern realities.
Keyword:
Code reviews
Code review smells
Process smells Code smells
Focus group
Empirical study
Mining software repositories

期刊

Journal of Systems and Software 封面图
Journal of Systems and Software
IF:
4.1
论文数:
5.5K
被引数:
8.4K

机构

I
ihsan dogramaci bilkent university
学者数:
3.6K
论文数: 3.6K
被引数: 8
University System of Maryland 封面图
University System of Maryland
学者数:
6.5W
论文数: 5.6W
被引数: 113
引用论文

引用论文

An empirical study of the impact of modern code review practices on software quality
err2015-04-25
err208
PREAI
errMcIntosh, Shane; Kamei, Yasutaka; Adams, Bram; Hassan, Ahmed E.
err分享
err收藏
From proprietary to open source tools in information systems development
err2004-01-01
err8
PREAI
errSerrano, N; Calzada, S; Sarriegni, JM; Ciordia, I
err分享
err收藏
Does code quality affect pull request acceptance? An empirical study
err2021-01-01
err20
errOAAI
errLenarduzzi, Valentina; Nikkola, Vili; Saarimaki, Nyyti; Taibi, Davide
err分享
err收藏
An exploratory study of the impact of antipatterns on class change- and fault-proneness
err2011-08-06
err291
PREAI
errKhomh, Foutse; Di Penta, Massimiliano; Gueheneuc, Yann-Gael; Antoniol, Giuliano
err分享
err收藏
Evaluating the agreement among technical debt measurement tools: building an empirical benchmark of technical debt liabilities
err2020-08-26
err25
PREAI
errAmanatidis, Theodoros; Mittas, Nikolaos; Moschou, Athanasia; Chatzigeorgiou, Alexander; Ampatzoglou, Apostolos; Angelis, Lefteris
err分享
err收藏
学者 查看更多内容